Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediafile: prefer latin-1 encoding for ID3 APIC descriptions. Fixes #899 #2270

Merged
merged 2 commits into from
Nov 19, 2016
Merged

mediafile: prefer latin-1 encoding for ID3 APIC descriptions. Fixes #899 #2270

merged 2 commits into from
Nov 19, 2016

Conversation

lazka
Copy link
Contributor

@lazka lazka commented Nov 18, 2016

iTunes has problems with everything but latin-1
Try to use latin-1 if possible and fall back to utf-16.



iTunes has problems with everything but latin-1
Try to use latin-1 if possible and fall back to utf-16.
@sampsyo
Copy link
Member

sampsyo commented Nov 18, 2016

Cool! This seems like a reasonable policy. And as far as I can tell, this is the right thing to do on v2.4, right? There's no sense in preferring UTF-8 on v2.4 and Latin-1 on v2.3?

@lazka
Copy link
Contributor Author

lazka commented Nov 18, 2016

And as far as I can tell, this is the right thing to do on v2.4, right? There's no sense in preferring UTF-8 on v2.4 and Latin-1 on v2.3?

See #899 (comment)

utf-16 and latin-1 are the only working encodings in both cases.

An alternative strategy would be utf-16 if desc else latin-1 (empty utf-16 doesn't work) but preferring latin-1 seems like a better choice given the problems described in #2264

@gboysko
Copy link

gboysko commented Nov 18, 2016

This change looks great to me. My only suggestion would be to use the symbolic constants (mutagen.id3.Encoding.UTF-16, etc) instead of the numeric values (0, 1).

@gboysko
Copy link

gboysko commented Nov 19, 2016

Thanks @lazka. Looks great! I'm eager to try it out as soon as it gets merged!

@sampsyo sampsyo merged commit 31f9112 into beetbox:master Nov 19, 2016
sampsyo added a commit that referenced this pull request Nov 19, 2016
mediafile: prefer latin-1 encoding for ID3 APIC descriptions. Fixes #899
sampsyo added a commit that referenced this pull request Nov 19, 2016
@sampsyo
Copy link
Member

sampsyo commented Nov 19, 2016

Yes, thank you, @lazka! I've merged the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants