Add Composer, Lyricist and Arranger tags #2333

ibmibmibm · 2016-12-20T13:50:59Z

MusicBrainz provids composer, lyricist and arranger infomations related
to individual recordings. This commit adds query parameters to fetch them, and
write down to media files.

Tagging mapping is implemented according MusicBrainz Picard's data:
https://picard.musicbrainz.org/docs/mappings/

Signed-off-by: Shen-Ta Hsieh ibmibmibm.tw@gmail.com

ibmibmibm · 2016-12-20T13:53:16Z

This pr implement some fields of #1547 and #507, and implement part of #506, while not supported #505.

sampsyo

Wow; thank you! This is quite complete—it's awesome that you were able to put together the MediaFile component too. ✨

Can you please add the new fields to test_mediafile.py so they get exercised in our test suite?

sampsyo · 2016-12-20T16:31:59Z

beets/autotag/__init__.py

+    if track_info.composer is not None:
+        item.composer = track_info.composer
+    if track_info.arranger is not None:
+        item.arranger = track_info.arranger


Can you please add a blank line between this stanza and the comment below?

MusicBrainz provids composer, lyricist and arranger infomations related to individual recordings. This commit adds query parameters to fetch them, and write down to media files. Tagging mapping is implemented according MusicBrainz Picard's data: https://picard.musicbrainz.org/docs/mappings/ Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>

ibmibmibm · 2016-12-20T17:57:47Z

As reminder, standalong recording's relation fetching needs this pull request, so we'll need a newer version of musicbrainzngs not yet released.

sampsyo · 2016-12-20T19:34:45Z

Ah, got it—thanks. So it sounds like we have two options:

Don't merge this until there's a new release of the client library.
Add some version checking so we just don't get the data on the current version of the library.

Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>

ibmibmibm · 2016-12-21T02:15:02Z

I've add a commit that automatically detects old version of musicbrainzngs, and disable this feature.

Add Composer, Lyricist and Arranger tags

sampsyo · 2016-12-21T16:18:23Z

Wonderful; thank you! This feature detection appears to work perfectly. This is all merged up. ✨

The new MediaFile tags in #2333 mean that the `test_unicode_path` test will write new tags to this test fixture file.

dosoe · 2017-05-08T11:30:18Z

Hi! I'm using the 'composer' tag, but it doesn't always seem to work. As an example, I have a few tracks from https://musicbrainz.org/release/a334fe44-27a5-43dd-b1da-369ddad5cde7 where beet info doesn't even give me a composer tag, and beet info -l gives me an empty composer track. However on MB they all have a work and a composer linked to them.

ibmibmibm · 2017-05-10T22:45:33Z

Did you upgrade your musicbrainzngs?

dosoe · 2017-05-11T10:06:27Z

I have musicbrainzngs version 0.6.2 from the community repo on an arch linux, I don't have the git version from the AUR.
Is the git version better?

ibmibmibm · 2017-05-13T02:46:25Z

You'll need git version of musicbrainzngs while 0.7 is not released yet.

dosoe · 2017-05-15T20:37:17Z

I have an issue about the 'arranger' tag: In this pull request the 'arranger' tag is fetched as a tag of a recording. On MB there is another 'arranger' tag that is a tag of a work. Should we merge these two tags (fetch both in the tag 'arranger' and the corresponding 'arranger_sort') or should there be a 'recording_arranger' and a 'work_arranger'? The second one would be more rigorous but we might then end up with stuff like 'recording_arranger_sort' and 'recording_arranger_disambig' which starts to be ridiculously long.
I have actually never encountered an occurence of 'arranger' as a recording tag, but I'm specialized on classical music, where 'arranger' is always related to a work, maybe other styles have it (I would like to check it up or link to examples, but MB is currently down).

dosoe · 2017-05-15T20:49:56Z

Also, usually, for operas, there is another term for lyricist (librettist) which has his separate term in MB. Should I create a new tag for that or should I just fetch him in the lyricist tag?

sampsyo · 2017-05-16T15:42:48Z

Some of these questions overlap with MusicBrainz style questions—maybe it would be useful to get input from #musicbrainz on IRC?

dosoe · 2017-05-16T17:09:27Z

Ok after some discussion on MB IRC channel: work-arrangers are mostly in the context of classical music, when a specific arrangement is played by different people (as Fresco said: However, since classicial music has a different tradition with regards to several "groups" performing the same arrangement, it makes more sense to make a new Work for these, so we can be sure that we're saying "these people are actually really playing the same arrangement, and not just the same Work that happens to have been arranged by the same )
recording-arrangers are more common in 'modern' music where one group makes his version of a popular piece/song.
The distinction between lyricist and librettist is that librettist is basically reserved to stage-works (opera, musical and oratorio-like works) and lyricist gets the rest. It can get confusing because inside a musical there can be songs that are not written by the librettist of the musical, they have their own... lyricist.

It seems pretty clear to anyone that work-arranger and recording arranger can be merged if necessary (maybe we can put them both into the 'arranger' tag since he gets written on the file but also keep separate tags for them if it's not too cumbersome).

For librettist and lyricist there seems to be more opposition, I propose we keep them separate.

eziobandara · 2020-10-11T11:34:28Z

MusicBrainz provids composer, lyricist and arranger infomations related
to individual recordings. This commit adds query parameters to fetch them, and
write down to media files.

Tagging mapping is implemented according MusicBrainz Picard's data:
https://picard.musicbrainz.org/docs/mappings/

Signed-off-by: Shen-Ta Hsieh ibmibmibm.tw@gmail.com

I've no programming knowledge. Can you please help me with adding lyricist to my mp3s?

dosoe · 2020-10-21T10:56:08Z

Hi! Just check out https://beets.readthedocs.io/en/stable/guides/main.html .

ibmibmibm force-pushed the master branch 3 times, most recently from 4363f63 to 2a7d314 Compare December 20, 2016 14:45

sampsyo requested changes Dec 20, 2016

View reviewed changes

ibmibmibm force-pushed the master branch from 2a7d314 to 7060b51 Compare December 20, 2016 17:53

sampsyo approved these changes Dec 20, 2016

View reviewed changes

add compatibility to old version of musicbrainzngs

97e5581

Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>

sampsyo merged commit 97e5581 into beetbox:master Dec 21, 2016

sampsyo added a commit that referenced this pull request Dec 21, 2016

Merge pull request #2333 from ibmibmibm/master

85119f7

Add Composer, Lyricist and Arranger tags

sampsyo added a commit that referenced this pull request Dec 21, 2016

Changelog for #2333

3528a67

sampsyo added a commit that referenced this pull request Dec 22, 2016

Remove stray prints (#2333)

8cc2ac5

sampsyo added a commit that referenced this pull request Dec 26, 2016

Update test file for new set of tags

8408264

The new MediaFile tags in #2333 mean that the `test_unicode_path` test will write new tags to this test fixture file.

sampsyo mentioned this pull request Feb 25, 2017

Fetch work title from MusicBrainz #2452

Open

sampsyo mentioned this pull request Apr 15, 2017

add composer_sort and arranger_sort fields #2519

Closed

mhendu mentioned this pull request Jul 2, 2017

Changes to add work id as a tag. #2619

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Composer, Lyricist and Arranger tags #2333

Add Composer, Lyricist and Arranger tags #2333

ibmibmibm commented Dec 20, 2016

ibmibmibm commented Dec 20, 2016 •

edited

Loading

sampsyo left a comment

sampsyo Dec 20, 2016

ibmibmibm Dec 20, 2016

ibmibmibm commented Dec 20, 2016

sampsyo commented Dec 20, 2016

ibmibmibm commented Dec 21, 2016

sampsyo commented Dec 21, 2016

dosoe commented May 8, 2017

ibmibmibm commented May 10, 2017

dosoe commented May 11, 2017 •

edited

Loading

ibmibmibm commented May 13, 2017

dosoe commented May 15, 2017

dosoe commented May 15, 2017

sampsyo commented May 16, 2017

dosoe commented May 16, 2017 •

edited

Loading

eziobandara commented Oct 11, 2020

dosoe commented Oct 21, 2020

Add Composer, Lyricist and Arranger tags #2333

Add Composer, Lyricist and Arranger tags #2333

Conversation

ibmibmibm commented Dec 20, 2016

ibmibmibm commented Dec 20, 2016 • edited Loading

sampsyo left a comment

Choose a reason for hiding this comment

sampsyo Dec 20, 2016

Choose a reason for hiding this comment

ibmibmibm Dec 20, 2016

Choose a reason for hiding this comment

ibmibmibm commented Dec 20, 2016

sampsyo commented Dec 20, 2016

ibmibmibm commented Dec 21, 2016

sampsyo commented Dec 21, 2016

dosoe commented May 8, 2017

ibmibmibm commented May 10, 2017

dosoe commented May 11, 2017 • edited Loading

ibmibmibm commented May 13, 2017

dosoe commented May 15, 2017

dosoe commented May 15, 2017

sampsyo commented May 16, 2017

dosoe commented May 16, 2017 • edited Loading

eziobandara commented Oct 11, 2020

dosoe commented Oct 21, 2020

ibmibmibm commented Dec 20, 2016 •

edited

Loading

dosoe commented May 11, 2017 •

edited

Loading

dosoe commented May 16, 2017 •

edited

Loading