-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a plugin to update a Kodi music library #2411
Conversation
I created one for an older version before, but it didn't work since the change to Python 3. So I created a new one that works.
json and requests.BasicAuthentication
Cool; looks good so far! We should include this alongside our other It looks like this needs a few changes to be ready to merge:
|
u'host': u'localhost', | ||
u'port': 8080, | ||
u'user': u'kodi', | ||
u'pwd': u'kodi'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should set
config['kodi']['pwd'].redact = True
here to hide the password from beet config
output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
Sorry for the delay! I'm not using github very actively so I didn't notice the comments :) I'll see what I can do about the travis build failing, it's probably something really stupid since I'm not that familiar with Python. I'll deal with the header and documentation once I get that build sorted. |
Awesome; thank you for looking into it! For what it's worth, it's pretty easy to run the style checker locally. You can just run |
Also added config['kodi']['pwd'].redact = True as suggested.
Hmm, I didn't know python is this picky with all sorts of things :) Nice learning experience. |
Yay, it works :) I added the documentation now too. |
By the way! Since I'm an Android developer, I was thinking about making a beets remote control app. I don't know how useful that'd actually be, but it would be cool for sure ;) It would require a jsonrpc or similar plugin for beets first, though. |
And now it's failing thanks to the documentation file. How do I make it not check that file? |
Hey, thanks again for the revisions! The right fix here for that docs issue, listed here:
is to add the new document to the table of contents for plugin documentation. I'll do that now… |
OK, changes pushed. Let's see what the CI says! An Android or other non-CLI frontend for beets is a really interesting idea, and it's something that we toss around from time to time. I even noticed this effort on GitHub a while back. You're right that what we need is an API—and there's a larger effort at foot there too. Specifically, take a look at the AURA project, where we're trying to define what a standard API for beets would look like. Currently, it's read-only, but I'd love to hear your input about how to make it capable of supporting editing too! |
That looks like a pretty good spec already! |
Cool! I'd be interested to collaborate on making this into a real API if you ever want to get started on that Android client. |
Add a plugin to update a Kodi music library
This plugin is all merged up! ✨ Thanks again for writing it. |
Awesome, glad I could contribute :) |
I created one for an older version before, but it didn't work since the change to Python 3. So I created a new one that works.