Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a 'move' option to the importer's CLI. #2429

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Adding a 'move' option to the importer's CLI. #2429

merged 1 commit into from
Feb 9, 2017

Conversation

karpinski
Copy link
Contributor

@jackwilsdon
Copy link
Member

Thanks for the PR @karpinski! Looks good to me, could you add a changelog entry?

@karpinski
Copy link
Contributor Author

Done

jackwilsdon
jackwilsdon requested changes Feb 7, 2017
View reviewed changes
docs/changelog.rst Outdated
@@ -22,6 +22,8 @@ New features:
value. The argument can be any two characters that represent the left and
right brackets. It defaults to `[]` and can also be blank to turn off
bracketing. :bug:`2397` :bug:`2399`
* Added a ``--move`` or ``-m`` option to the importer so that the files can be
moved to the library instead of being copied or added "in place".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a reference to both #2252 and this PR (#2429) to the entry?

You can add it by putting this at the end of the line: :bug:`2252` :bug:`2429`

Thanks again! 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jackwilsdon
Copy link
Member

Looks good to me, what do you think @sampsyo?

@sampsyo
Copy link
Member

sampsyo commented Feb 9, 2017

This looks perfect. Thank you, @karpinski! And thanks to @jackwilsdon for reviewing.

@sampsyo sampsyo merged commit ce3ee8b into beetbox:master Feb 9, 2017
@sampsyo sampsyo mentioned this pull request Feb 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwilsdon jackwilsdon jackwilsdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karpinski @jackwilsdon @sampsyo