Remove supported formats check from absubmit #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error when deleting the file under Windows
Also lower the logging to warning if the extractor fails to analyse a file
|
This looks perfect; thank you! Would you mind adding a quick changelog entry? I think the error message is probably fine… if it becomes a problem, we can consider adding the full output from the underlying tool to the debug output, which might help users diagnose when something goes wrong. |
sampsyo
added a commit
that referenced
this pull request
Mar 18, 2017
Remove supported formats check from absubmit
|
All merged up! Thank you so much for your help with this, @inytar. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take on a solution for #2471. It removes the check for supported formats from the plugin and lowers the logging level when the extractor fails to warning.
Still wondering if we want to edit the log message to indicate that the reason for failing might be a wrong file format. The supported formats are mentioned in the documentation.