Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a terminal bell if interaction from the user is required, according to this issue: https://github.com/beetbox/beets/issues/2366 #2495

Merged
merged 7 commits into from
Mar 28, 2017
Merged

Added a terminal bell if interaction from the user is required, according to this issue: https://github.com/beetbox/beets/issues/2366 #2495

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2fbc7f0
Added a terminal bell if interaction from the user is required
SpirosChadoulos Mar 26, 2017
5128b95
Added bell when user interaction is needed
SpirosChadoulos Mar 26, 2017
28c423b
Added bell when user interaction is needed
SpirosChadoulos Mar 26, 2017
c605a91
Added an if statement that allows the bell ring according to the user…
SpirosChadoulos Mar 27, 2017
2189682
small changes for the bell issue
SpirosChadoulos Mar 27, 2017
70ef6e7
Fix heading underline length
sampsyo Mar 28, 2017
ffdeb1e
Changelog/thanks for #2495
sampsyo Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions beets/ui/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,8 @@ def _get_choices(self, task):
Returns a list of `PromptChoice`s.
"""
# Standard, built-in choices.
#Bell ring to alert the user that he has to interfere with the cmd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Travis report: https://travis-ci.org/beetbox/beets/jobs/215295136#L885

is telling you to put a space after the # character in your comments. In addition, please use complete sentences in comments that end with periods—and there's no need to use abbreviations like "cmd".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll work on it. Thank you.

print('\a')
choices = [
PromptChoice(u's', u'Skip',
lambda s, t: importer.action.SKIP),
Expand Down