Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default replace for - to _ #2509

Merged
merged 2 commits into from
Apr 16, 2017
Merged

Add default replace for - to _ #2509

merged 2 commits into from
Apr 16, 2017

Conversation

mattmurch
Copy link
Contributor

@mattmurch mattmurch commented Apr 12, 2017

Also updated changelog and docs.

Resolves: #549

@mention-bot
Copy link

@mattmurch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sampsyo, @mrmachine and @geigerzaehler to be potential reviewers.

@sampsyo
Copy link
Member

sampsyo commented Apr 12, 2017

Thanks for the PR! But is #459 really what you meant to link to?

@mattmurch
Copy link
Contributor Author

Sorry, I meant #549. I'll push a fix in a second.

Also updated changelog and docs.

Resolves: beetbox#549
@mattmurch
Copy link
Contributor Author

Done

@mattmurch
Copy link
Contributor Author

There is a Travis CI failure in the line I introduced in the changelog. I wrote line 55 to mimic the surrounding code, but I do not understand what it is doing. Do you know what is happening?

@@ -52,6 +52,7 @@ New features:

Fixes:

* :doc:`/beets/config_default`: Added default replace for - to _. :bug:`549`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha; this is just a ReST syntax thing: the :doc: directive is for linking to other *.rst pages. We actually only really use this in the changelog for plugins, where the name of the ReST doc is the same as the name of the Python source file—here, you don't need to use a prefix. You might want to use :ref:`replace` inline in the sentence to link to the relevant config option in the configuration page, for example.

@sampsyo sampsyo merged commit 6e29514 into beetbox:master Apr 16, 2017
sampsyo added a commit that referenced this pull request Apr 16, 2017
Add default replace for - to _
sampsyo added a commit that referenced this pull request Apr 16, 2017
@sampsyo
Copy link
Member

sampsyo commented Apr 16, 2017

Thanks! Merged, with a slightly updated changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants