-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default replace for - to _ #2509
Conversation
@mattmurch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sampsyo, @mrmachine and @geigerzaehler to be potential reviewers. |
Thanks for the PR! But is #459 really what you meant to link to? |
Sorry, I meant #549. I'll push a fix in a second. |
Also updated changelog and docs. Resolves: beetbox#549
Done |
There is a Travis CI failure in the line I introduced in the changelog. I wrote line 55 to mimic the surrounding code, but I do not understand what it is doing. Do you know what is happening? |
docs/changelog.rst
Outdated
@@ -52,6 +52,7 @@ New features: | |||
|
|||
Fixes: | |||
|
|||
* :doc:`/beets/config_default`: Added default replace for - to _. :bug:`549` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha; this is just a ReST syntax thing: the :doc:
directive is for linking to other *.rst
pages. We actually only really use this in the changelog for plugins, where the name of the ReST doc is the same as the name of the Python source file—here, you don't need to use a prefix. You might want to use :ref:`replace`
inline in the sentence to link to the relevant config option in the configuration page, for example.
Add default replace for - to _
Thanks! Merged, with a slightly updated changelog entry. |
Also updated changelog and docs.
Resolves: #549