Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename error #2523

Merged
merged 4 commits into from
May 1, 2017
Merged

Rename error #2523

merged 4 commits into from
May 1, 2017

Commits on Apr 22, 2017

  1. Rename InvalidQueryArgumentTypeError to `InvalidQueryArgumentValueE… 

    …rror`

The way we use `InvalidQueryArgumentTypeError` is more akin to a `ValueError` than a `TypeError`. For example, we try to parse a string as an int, float, or date, but the parsing fails - there was nothing wrong with the type of the variable (string), but its contents were not parseable into the type we wanted - there was a problem with the value of the string.
    @discopatrick
    discopatrick committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    5841752 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rename-error 

    # Conflicts:
#	beets/dbcore/query.py
    @discopatrick
    discopatrick committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    bd48559 View commit details
    Browse the repository at this point in the history

  3. Raise the correct error type 

    The incorrect error type was reintroduced in the previous merge commit.
    @discopatrick
    discopatrick committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    63cd799 View commit details
    Browse the repository at this point in the history

  4. Adjust indentation to pass flake8 tests

    @discopatrick
    discopatrick committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    d24b373 View commit details
    Browse the repository at this point in the history