Close stdin when performing command_output()
#2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2017 15:01
This should fix 2488, where beet convert would prevent further inputs.
|
I can't see from the PR title or description what problem this is supposed to solve… ? |
|
@Freso : Sorry I got confused between writing commit messages, PR content, short PR title, and changelog. Eh, can get a bit repetitive. Also apparently there is a 2/3 issue :'( |
This should make #2524 pass
|
That's better! |
sampsyo
approved these changes
Apr 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2488 where some commands, mainly
beet convertwould prevent further inputs.I've been running with the solution proposed by @sampsyo for some time now and I believe it does indeed suppress this behaviour.
@jansol, could you confirm this fixes problems on your end as well?
I don't know how to test for this however.