Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of python-itunes #2540

Merged
merged 2 commits into from
May 3, 2017
Merged

Remove mention of python-itunes #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e548b
Remove mention of python-itunes
owcz May 3, 2017
8b4b64d
Changelog for #2540
owcz May 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ Fixes:
ignored. Thanks to :user:`discopatrick`. :bug:`2513` :bug:`2517`
* When the SQLite database stops being accessible, we now print a friendly
error message. Thanks to :user:`Mary011196`. :bug:`1676` :bug:`2508`
* :doc:`plugins/fetchart`'s iTunes Store artwork lookup no longer recommended
in documentation, as the unmaintained `python-itunes`_ is broken. Want
to adopt it? :bug:`2371` :bug:`1610`

.. _python-itunes: https://github.com/ocelma/python-itunes


1.4.3 (January 9, 2017)
Expand Down
21 changes: 6 additions & 15 deletions docs/plugins/fetchart.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ file. The available options are:
(``enforce_ratio: 0.5%``). Default: ``no``.
- **sources**: List of sources to search for images. An asterisk `*` expands
to all available sources.
Default: ``filesystem coverart itunes amazon albumart``, i.e., everything but
Default: ``filesystem coverart amazon albumart``, i.e., everything but
``wikipedia``, ``google`` and ``fanarttv``. Enable those sources for more
matches at the cost of some speed. They are searched in the given order,
thus in the default config, no remote (Web) art source are queried if
Expand Down Expand Up @@ -82,13 +82,13 @@ or `Pillow`_.
.. _ImageMagick: http://www.imagemagick.org/

Here's an example that makes plugin select only images that contain *front* or
*back* keywords in their filenames and prioritizes the iTunes source over
*back* keywords in their filenames and prioritizes the Amazon source over
others::

fetchart:
cautious: true
cover_names: front back
sources: itunes *
sources: amazon *


Manually Fetching Album Art
Expand Down Expand Up @@ -128,7 +128,7 @@ Album Art Sources
-----------------

By default, this plugin searches for art in the local filesystem as well as on
the Cover Art Archive, the iTunes Store, Amazon, and AlbumArt.org, in that
the Cover Art Archive, Amazon, and AlbumArt.org, in that
order.
You can reorder the sources or remove
some to speed up the process using the ``sources`` configuration option.
Expand All @@ -146,18 +146,9 @@ described above. For "as-is" imports (and non-autotagged imports using the
iTunes Store
''''''''''''

To use the iTunes Store as an art source, install the `python-itunes`_
library. You can do this using `pip`_, like so::
There is currently `no plugin`_ to use the iTunes Store as an art source.

$ pip install https://github.com/ocelma/python-itunes/archive/master.zip

(There's currently `a problem`_ that prevents a plain ``pip install
python-itunes`` from working.)
Once the library is installed, the plugin will use it to search automatically.

.. _a problem: https://github.com/ocelma/python-itunes/issues/9
.. _python-itunes: https://github.com/ocelma/python-itunes
.. _pip: http://www.pip-installer.org/
.. _no plugin: https://github.com/beetbox/beets/issues/2371

Google custom search
''''''''''''''''''''
Expand Down