Document gapless mp3 encoding. #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smlx, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sampsyo, @Kraymer and @geigerzaehler to be potential reviewers. |
|
High quality .rst you produced here ! 🦈 |
Kraymer
suggested changes
May 25, 2017
docs/plugins/convert.rst
Outdated
| :: | ||
|
|
||
| #!/bin/sh | ||
| /usr/bin/ffmpeg -i "$1" -f wav - | /usr/bin/lame -V 2 --noreplaygain - "$2" |
There was a problem hiding this comment.
Maybe don't put the absolute paths which may vary :
ffmpeg -i "$1" -f wav - | lame -V 2 --noreplaygain - "$2"
There was a problem hiding this comment.
Sure, should be fixed now! 😄
Kraymer
approved these changes
May 26, 2017
sampsyo
added a commit
that referenced
this pull request
Jun 11, 2017
Document gapless mp3 encoding.
|
Thank you for adding all this detail! I compressed things down a little bit for brevity and merged. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1741.