Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix importfeeds plugin on Python 3. #2658

Merged
merged 1 commit into from
Aug 20, 2017
Merged

Fix importfeeds plugin on Python 3. #2658

merged 1 commit into from
Aug 20, 2017

Conversation

djl
Copy link
Member

@djl djl commented Aug 18, 2017

Submitted as a pull request to run the tests because I can't get tox to work correctly.

@mention-bot
Copy link

@djl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brunal, @Kraymer and @jrobeson to be potential reviewers.

@sampsyo
Copy link
Member

sampsyo commented Aug 20, 2017

Thank you for putting this together! This is to address #2467, right?

If so, this looks much cleaner than it did before, and it should fix the problem. 👍 ✨

@djl djl merged commit f909f09 into master Aug 20, 2017
@djl djl deleted the fiximportfeeds branch August 20, 2017 10:29
sampsyo added a commit that referenced this pull request Aug 20, 2017
@sampsyo
Changelog for #2467/#2658
c89186a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djl @mention-bot @sampsyo