Modify task recommendation and candidates #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, subsequent candidates can be exposed to plugins instead of just used locally to interact with the user.
|
Ouch, it seems this patch didn't make it to 1.4.6 :( |
|
Great! If it's working for you, I'll make a note to try out a few things and then merge it. |
|
can't understand, but wish can get to a better place. |
|
Alright; I have finally merged this! Thanks for your patience. |
sampsyo
added a commit
that referenced
this pull request
Jan 31, 2018
Modify task recommendation and candidates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2441.
The problem in that bug is that the
recandcandidatesproduced by subsequent actions, like manual searching, were just kept in local variables instead of assigning them on theImportTaskobject. That meant that plugins and such could not inspect these new candidates; they only saw the old ones (if they existed).I'm not sure how wide-ranging the effects of this change will be, so some thorough testing here would be greatly appreciated!