Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Plugin: Added dont_convert Option #2751

Merged
merged 5 commits into from
Nov 30, 2017
Merged

Conversation

Stunner
Copy link
Contributor

@Stunner Stunner commented Nov 30, 2017

Addresses #2732. I changed the name from noconvert to a more intuitive dont_convert which I think falls better in-line with the other options of the convert plugin (i.e. never_convert_lossy_files).

@sampsyo
Copy link
Member

sampsyo commented Nov 30, 2017

Nice! This is a really straightforward, simple solution to the problem.

Would you mind adding a quick changelog entry about the feature?

Also, I have to admit that I kind of prefer the shorter name for the option. I’ve never really liked the verbosity of never_etc_etc, which is sort incongruous with the rest of our option names—maybe we should have worked harder on that. And the missing apostrophe in the contraction dont is a little more strange, in my opinion.

Other name options include no_convert and copy_only.

@sampsyo
Copy link
Member

sampsyo commented Nov 30, 2017

This is perfect! ✨ Thanks for implementing this.

@sampsyo sampsyo merged commit 28cb79b into beetbox:master Nov 30, 2017
@Stunner
Copy link
Contributor Author

Stunner commented Nov 30, 2017

Thank you @sampsyo for being such an awesome and active maintainer of this wonderful project!

@Stunner Stunner deleted the dont-convert branch November 30, 2017 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants