Fix fragile parsing of bs1770gain output #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bs1770gain is sorting the filenames internally, so in some corner cases it returns the results in a different order from the command-line arguments. This patch uses the --xml option of bs1770gain (introduced in 0.4.6) in order to read the filenames reliably.
|
Thanks; this looks great! Parsing the XML from the output seems more robust than our old regex parser anyway. As with #2778, can you please add a changelog entry? It might also be useful to add a minimum bs1770gain version to the plugin's docs. |
|
Perfect! Thank you for these updates—and for finding the problem in the first place. ✨ Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bs1770gain is sorting the filenames internally, so in some corner cases it returns the results in a different order from the command-line arguments.
This patch uses the --xml option of bs1770gain (introduced in 0.4.6) in order to read the filenames reliably.