Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small performance optimization when fetching items from library. #2798

Merged
merged 4 commits into from
Mar 23, 2019
Merged

Small performance optimization when fetching items from library. #2798

merged 4 commits into from
Mar 23, 2019

Commits on Mar 23, 2019

  1. Small performance optimization when fetching items from library. 

    Fetch flexible attributes once for all items instead of once per
item. For queries with larger result sets this drastically cuts
down the number of issued sqlite queries.
    @pprkut
    pprkut committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    1e1ddd2 View commit details
    Browse the repository at this point in the history

  2. Query flexible attributes already in _fetch() 

    This resolves the query length and potential security problems,
while keeping the performance benefits.
    @pprkut
    pprkut committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    31ec222 View commit details
    Browse the repository at this point in the history

  3. Improve documentation

    @pprkut
    pprkut committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    5494c8b View commit details
    Browse the repository at this point in the history

  4. Account for items that do not have flexible attributes

    @pprkut
    pprkut committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    7c568aa View commit details
    Browse the repository at this point in the history