Make sure release events are selected in preferred order. #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, release events were selected based on the order that MusicBrainz listed them rather than the order defined in config.yaml.
|
Nice! This is an elegant solution to a subtle problem. Would you mind adding a changelog entry describing the problem? Then this looks ready to merge. One tiny aside: I note that this will have slightly different performance (possibly a larger number of total loop iterations, if there are more releases than configured countries). But this is very unlikely to actually matter. |
|
I always forget about changelog entries! |
|
Perfect. Thanks for adding that! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, release events were selected based on the order that MusicBrainz listed them rather than the order defined in config.yaml.
Opening this as a pull request instead of pushing directly because this may* cause large metadata changes the next time someone runs
beet mbsync. But it should improve the metadata, making it align better with a user's preferred countries.* I ran this over my entire collection of around 4000 albums and it changed only eight.