Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumping time in beets.js #2822

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Fix jumping time in beets.js #2822

merged 2 commits into from
Feb 26, 2018

Conversation

waweic
Copy link
Contributor

@waweic waweic commented Feb 26, 2018

Round was used instead of floor, so the minute counter jumped after each 30 seconds

Round was used instead of floor
@sampsyo
Copy link
Member

sampsyo commented Feb 26, 2018

Awesome; thank you. That was a dumb mistake. Would you mind adding a quick changelog entry about the fix?

@waweic
Copy link
Contributor Author

waweic commented Feb 26, 2018

You are welcome, of course. I have never contributed to a changelog before and don't really know how to write an entry. How would you formulate that?

@sampsyo
Copy link
Member

sampsyo commented Feb 26, 2018

Sure! Just add a bullet to the end of the current "Fixes" list at the top of changelog.rst saying, for example:

* :doc:`/plugins/web`: The time display in the web interface would incorrectly jump
  at the 30-second mark of every minute. Now, it correctly changes over at zero
  seconds. :bug:`2822`

@waweic
Copy link
Contributor Author

waweic commented Feb 26, 2018

Thanks! If you don't mind, I will just take this for the changelog entry.

Add the changelog entry
@sampsyo
Copy link
Member

sampsyo commented Feb 26, 2018

Looks great; thank you! ✨

@sampsyo sampsyo merged commit e938ad3 into beetbox:master Feb 26, 2018
@waweic waweic deleted the patch-1 branch February 27, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants