Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed flask cors import #2980

Merged
merged 1 commit into from
Jul 10, 2018
Merged

changed flask cors import #2980

merged 1 commit into from
Jul 10, 2018

Conversation

rveachkc
Copy link
Contributor

@rveachkc rveachkc commented Jul 10, 2018

Per the Flask Documentation:

Extension imports

Extension imports of the form flask.ext.foo are deprecated, you should use flask_foo.

The old form still works, but Flask will issue a flask.exthook.ExtDeprecationWarning for each extension you import the old way. We also provide a migration utility called flask-ext-migrate that is supposed to automatically rewrite your imports for this.

This changes the CORS import from the deprecated form to the preferred form.

Issue #2979

@sampsyo
Copy link
Member

sampsyo commented Jul 10, 2018

Awesome; thank you! We should indeed be using the new package name. Nice work! ✨

@sampsyo sampsyo merged commit 1505ff0 into beetbox:master Jul 10, 2018
sampsyo added a commit that referenced this pull request Jul 10, 2018
sampsyo added a commit that referenced this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants