gmusic plugin fixes and additions #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmob
changed the title
sampsyo
reviewed
Aug 15, 2018
docs/plugins/gmusic.rst
Outdated
| This option only needs to be set if you receive an `InvalidDeviceId` | ||
| exception. Below the exception will be a list of valid device IDs. | ||
| Default: none. | ||
| - **oauth_filepath**: Filepath for oauth credentials file. | ||
| Default: none. |
There was a problem hiding this comment.
Maybe it’s worth explaining that this doesn’t mean that there is no OAuth file path by default; its location is just determined by the library.
Also, since it’s definitely a path, I recommend simplifying the name to either oauth_file or oauth_path.
beetsplug/gmusic.py
Outdated
| # Checks for OAuth2 credentials, | ||
| # if they don't exist - performs authorization | ||
| oauth_filepath = (self.config['oauth_filepath'].as_str() | ||
| or gmusicapi.clients.OAUTH_FILEPATH) |
There was a problem hiding this comment.
One possible simplification would be to put gmusicapi.clients.OAUTH_FILEPATH into the defaults dictionary for the plugin’s configuration. Then it wouldn’t be necessary to have an explicit fallback here.
|
Fantastic; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the
gmusicplugin is used, any command ran with beets will run thegmusicapioauth authentication even if it has nothing related togmusic.Example, using command "ls" triggers the auth (every command does, including "web"):
Fixed example, "ls" command does not trigger auth, but using one of the gmusic commands does:
