Improve error messages in case of sqlite errors #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Can you please write something about what you changed and why? Some examples would be extremely useful. |
|
[comments edited] |
|
That helps a lot; thanks!! Travis is complaining about a line that’s too long and needs to be wrapped: For grammar’s sake, can we please change the message to Could you also please include a changelog entry? |
|
Ah, got it!. yeah I will fix the text and the ci error |
|
Looks great; thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when beets is started and the database file is on e.g. a volume that is full beets quits with the message "database file could not be opened {path to file}". The original error message coming from sqlite is lost. the proposed patch attaches the original error as 'reason'. in the case of disk full it reads now "database file {path to file} could not be opened, reason: database or disk is full"
I have no idea how to create a test for it, because the test case either depends on a not-writeable database file or on a mock of sqlite