chroma: Bias toward looking up more relevant releases using date/country #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses match:preferred:countries/original_year: config options to determine whether the releases should be sorted by their respective fields. The behaviour is the same as before when the default config is used.
sampsyo
reviewed
Aug 31, 2018
beetsplug/chroma.py
Outdated
| year = date.get('year', 9999) | ||
| month = date.get('month', 99) | ||
| day = date.get('day', 99) | ||
| key = '{0:04d}{1:02d}{2:02d}'.format(year, month, day) |
There was a problem hiding this comment.
Any particular reason this produces a string instead of a tuple? Python will happily sort tuples indexwise:
>>> sorted([(1,2,3), (1,1,1)])
[(1, 1, 1), (1, 2, 3)]
beetsplug/chroma.py
Outdated
| @@ -88,16 +113,24 @@ def acoustid_match(log, path): | |||
| return None | |||
| _acoustids[path] = result['id'] | |||
|
|
|||
| # Get recording and releases from the result. | |||
| # Get recording and releases from the result, | |||
| # sorted by date and/or country depending on 'match'>'preferred' config. | |||
There was a problem hiding this comment.
We usually name config options using dot syntax. For example, "the match.preferred configuration option" here. Also, looks like this comment needs to get rewrapped.
beetsplug/chroma.py
Outdated
| for recording in result['recordings']: | ||
| recording_ids.append(recording['id']) | ||
| if 'releases' in recording: | ||
| release_ids += [rel['id'] for rel in recording['releases']] | ||
| releases.extend(recording['releases']) | ||
| country_patterns = config['match']['preferred']['countries'].as_str_seq() |
There was a problem hiding this comment.
A comment here might be in order to introduce the reason for all this sorting business.
|
Looks great; thanks!! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow releases from Acoustid lookup to be sorted by date/country
#3017