Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring of audio data tracks on import #3021

Merged
merged 2 commits into from
Sep 2, 2018
Merged

Conversation

fortes
Copy link
Member

@fortes fortes commented Sep 2, 2018

#1638 by @jdetrey changed the importer to take data tracks into imports. This adds a configuration option to disable that feature.

I'm proposing adding this since it seems like video tracks still get included sometimes in data-track-list, such as in this release where there is a multimedia track: http://musicbrainz.org/ws/2/release/cbc97377-05f3-4011-a8fa-0aaa1ca9ffd1?inc=artists+artist-credits+recordings+aliases

@fortes fortes requested a review from sampsyo September 2, 2018 14:11
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My only question is whether this option should be on by default. You probably have the default right already, but it would be worth considering flipping the default too.

@fortes
Copy link
Member Author

fortes commented Sep 2, 2018

@sampsyo I debating setting this to yes until I found the PR that just enabled the feature a few months ago, so I went conservative here in order to avoid breaking people's config.

I'd personally have this as yes by default, but can see the other side of the argument.

Will merge now, I figure we can always change the default in a separate PR.

@fortes fortes merged commit ce03e5a into master Sep 2, 2018
@fortes fortes deleted the ignore-data-tracks branch September 2, 2018 15:34
@sampsyo
Copy link
Member

sampsyo commented Sep 2, 2018

OK, sounds good! I would not object to switching the default to yes—this is a new enough feature that I doubt many people are relying on it. (We probably should have put this behind an option to begin with.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants