Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove default arg for lastgenre --force flag #3054

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

discopatrick
Copy link
Member

@discopatrick discopatrick commented Oct 16, 2018

To fix #2704

@sampsyo
Copy link
Member

sampsyo commented Oct 16, 2018

Looks right to me! 😃 ✨

@discopatrick
Copy link
Member Author

@sampsyo I marked as WIP because this is not tested! But if you're confident to merge, please go ahead.

@arcresu
Copy link
Member

arcresu commented Apr 6, 2019

FWIW I was able to reproduce the original issue and tested this change at it looks like it does the trick.

@sampsyo
Copy link
Member

sampsyo commented Apr 6, 2019

Yay!! Merged. ✨

@sampsyo sampsyo merged commit 9c7a313 into beetbox:master Apr 6, 2019
sampsyo added a commit that referenced this pull request Apr 6, 2019
WIP: Remove `default` arg for `lastgenre --force` flag
sampsyo added a commit that referenced this pull request Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lastgenre: force config option doesn’t work
3 participants