Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaygain backend r128gain #3055

Closed
wants to merge 6 commits into from
Closed

Replaygain backend r128gain #3055

wants to merge 6 commits into from

Commits on Oct 17, 2018

  1. Allow other ReplayGain backends to support R128. 

    Previously using EBU R128 forced the use of the bs1770gain backend.
This change adds a whitelist of backends supporting R128. When the configured
backend is in that list it will also be used for R128 calculations. Otherwise
bs1770gain is still used as a default.

This should not change the overall behaviour of the program at all, but allow
for further R128-supporting backends to be added.
    @zsinskri
    zsinskri committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    aeb2ac5 View commit details
    Browse the repository at this point in the history

  2. Add r128gain ReplayGain backend. 

    Add a ReplayGain backend using the r128gain python module.
Its structure is largely based on the bs1770gain and GStreamer backends.
    @zsinskri
    zsinskri committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    4e2578a View commit details
    Browse the repository at this point in the history

  3. Document the r128gain ReplayGain backend. 

    Add documentation on the r128gain ReplayGain backend and list it as supporting
R128_ tags.
    @zsinskri
    zsinskri committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    351cd27 View commit details
    Browse the repository at this point in the history

  4. Test r128gain ReplayGain backend 

    Add tests for the r128gain ReplayGain backend that only run when r128gain is
present in the testing environment. This uses the existing ReplayGain test suite.
    @zsinskri
    zsinskri committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    ce07d43 View commit details
    Browse the repository at this point in the history

  5. Remove superfluous print. 

    Remove a print statement originally used for debugging purposes.
    @zsinskri
    zsinskri committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    b02957e View commit details
    Browse the repository at this point in the history

  6. Note that r128gain is beta software in docs. 

    Add a note to the documentation, that r128gain used by the r128gain replaygain
backend describes itself as beta software.
    @zsinskri
    zsinskri committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    ac089c5 View commit details
    Browse the repository at this point in the history