Fixed typo in convert when copying cover art #3063
Conversation
|
I don't think the travis errors come from my commit, I get the same flake errors when i checkout master. |
There was a problem hiding this comment.
Awesome; thanks for catching this. You're right that the style errors are not your fault; I've fixed those on master.
I left one comment inline. Also, while I know it seems trivial, would you mind adding a real quick changelog entry describing what you fixed?
beetsplug/convert.py
Outdated
| util.displayable_path(album.artpath), | ||
| util.displayable_path(dest)) | ||
| self._log.info(u'Copying cover art from {0}', | ||
| util.displayable_path(album.artpath)) |
There was a problem hiding this comment.
Any particular reason not to include both paths, as in from {0} to {1} here?
There was a problem hiding this comment.
Length. In my case it's printing the full path, which is quite long, so two of those would wrap the long line and not be very nice in the console. But as you wish, we can also only log the destination !
There was a problem hiding this comment.
I see! But the other messages here include both paths—for example, see the “Resizing” log message a few lines above. It would be nice if all of these were consistent (either way).
There was a problem hiding this comment.
Yeah you're right, i'm changing it.
|
Looks perfect; thank you! ✨ |
When the convert plugin is copying album arts, it logs
while it should say
from(ortothe source path). I first I thought my original covers were being overwritten. I fixed the critical issue.