-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaygain: target level refactor #3065
Commits on Jul 22, 2019
-
This test caused other tests to fail due to missing cleanup.
Configuration menu - View commit details
-
Copy full SHA for b9063a0 - Browse repository at this point
Copy the full SHA b9063a0View commit details -
replaygain: pass target_level and peak to backends
Configure the replaygain analysis by passing arguments to the Backends. This avoids the difference between ReplayGain and EBU r128 backends; every Backend can now fulfil both tasks. Additionally it eases Backend development as the difference between the two tag formats is now completely handled in the main Plugin, not in the Backends.
Configuration menu - View commit details
-
Copy full SHA for 0c8eead - Browse repository at this point
Copy the full SHA 0c8eeadView commit details -
replaygain: targetlevel and peak_method depends on tag format
Allow to configure the target level for R128_* tags separately from REPLAYGAIN_* tags and skip peak calculation for R128_* tags if possible.
Configuration menu - View commit details
-
Copy full SHA for e7e2c42 - Browse repository at this point
Copy the full SHA e7e2c42View commit details -
replaygain: add target_level test
Assert that analysing the same track with different target levels yields different gain adjustments.
Configuration menu - View commit details
-
Copy full SHA for 5a8bdb6 - Browse repository at this point
Copy the full SHA 5a8bdb6View commit details -
replaygain: add R128_* tag test
Assert that the replaygain plugin does not write REPLAYGAIN_* tags but R128_* tags, when instructed to do so. This test is skipped for the `command` backend as it does not support OPUS.
Configuration menu - View commit details
-
Copy full SHA for 88ab547 - Browse repository at this point
Copy the full SHA 88ab547View commit details -
update replaygain target level documentation
- document `r128_targetlevel` - explain difference between `targetlevel` and `r128_targetlevel` - deprecate `method` option: use `targetlevel` instead.
Configuration menu - View commit details
-
Copy full SHA for fbc8cc4 - Browse repository at this point
Copy the full SHA fbc8cc4View commit details -
changelog: new
r128_targetlevel
optionAdd changelog entries for the introduction of the `r128_targetlevel` configuration option, superseding the `method` option.
Configuration menu - View commit details
-
Copy full SHA for da602d7 - Browse repository at this point
Copy the full SHA da602d7View commit details
Commits on Jul 25, 2019
-
Apply improvements suggested in GitHub PullRequest beetbox#3065: - be idiomatic - 0 is falsy - check enum equality, not identity - mutate list by constructing a new one - improve documentation - fix a typo - do not mention deprecation of a config option
Configuration menu - View commit details
-
Copy full SHA for a9f70f8 - Browse repository at this point
Copy the full SHA a9f70f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3645df - Browse repository at this point
Copy the full SHA e3645dfView commit details