-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export plugin can now export path from library. #3084
Conversation
I didn't mean to reference this PR in #3085, oops! |
Ok. I see I need to better check the guidelines next time. |
I personally prefer amending the current commit (it leads to a cleaner history IMO), but it's up to you 👍 I'm going to leave the rest of this PR to someone else as I'm not familiar enough with what it's changing. |
…ed as field to export. Info plugin behaviour is unchanged.
I agree. Not sure yet how this is usually done. So I asked. |
@@ -239,4 +240,5 @@ def filter_(data): | |||
|
|||
|
|||
def identity(val): | |||
val.pop('path', None) # path is fetched from item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little odd to call this function identity
when it's not really an identity function. 😃 I'm going to fiddle around with this a little bit…
OK, merged with a small refinement in the below commit. Let me know if anything looks wrong, please! |
Export plugin can now export path from library.
Thanks. I will check within two days and let you know if there are problems. |
Exports path (file path) if specified in fields to export (with -i parameter). Only when exporting library fields, because file tags don't contain path. Info works as before. Path won't be displayed in the list even if user provides it in parameters.