Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acoustid_fingerprint type confusion #3097

Merged
merged 1 commit into from
Dec 21, 2018

Commits on Dec 19, 2018

  1. Fix acoustid_fingerprint type confusion

    Since pyacoustid returns the fingerprint as bytes (and thus causes the
    database to store a bytes/BLOB object), but the tag value is a string,
    the acoustid_fingerprint tag always causes file change when using beet's
    "write" command, even if the actual value didn't change.
    
    Issue beetbox#2942 describes the problem.
    
    This commit fixes that issue for newly imported/fingerprinted files. However,
    you still need to change the type of all acoustid_fingerprint fields
    that are already present in the database:
    
        $ sqlite3 beets.db
        SQLite version 3.26.0 2018-12-01 12:34:55
        Enter ".help" for usage hints.
        sqlite> UPDATE items SET acoustid_fingerprint = CAST(acoustid_fingerprint AS TEXT);
    Holzhaus committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    d2521d9 View commit details
    Browse the repository at this point in the history