beets update: dont move album art twice #3189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases #2419 was being hit not because users had moved the album art, but because:
with_album=True
, but doesn't update album.artpath in the DB becausestore=False
#3030 hides this error in most cases, but without this fix beets will still lose track of your album art, even if it doesn't throw, as evidenced by the test.
note: to fail without the fix, the test needs to add a second item to the album. this is because only the second item move actually moves the album cover, because the album's path is guessed from its first item's path, and the first item is stored after being moved.