Fix several deprecation warnings #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Python 3.3 the abstract base classes from `collections` are moved to the `collections.abc` module. From Python 3.8 they will be unavailable from their original location. https://docs.python.org/3/library/collections.abc.html
|
These all look perfect! Thanks again!! 🥞 |
sampsyo
added a commit
that referenced
this pull request
Apr 1, 2019
Fix several deprecation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the test suite with pytest in Python 3.7, it flagged a few distinct deprecation warnings. I see that the YAML one is handled in another PR, but this one addresses:
log.warn()should belog.warningcollectionswere moved tocollections.abcin Python 3.3 and will be unavailable from their original location in Python 3.8.plistlibmodule has a changed interface since Python 3.4