Fix for #2790 - acousticbrainz: Really small float values are stored as strings #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
reviewed
Apr 24, 2019
beetsplug/acousticbrainz.py
Outdated
| @@ -151,7 +176,7 @@ def _get_data(self, mbid): | |||
| return {} | |||
|
|
|||
| if res.status_code == 404: | |||
| self._log.info(u'recording ID {} not found', mbid) | |||
| self._log.info(u'recording ID \'{}\' not found', mbid) | |||
There was a problem hiding this comment.
Any particular reason to add these single quotes in these log statements? For the sake of the cleanliness of this PR, it would be awesome to leave that to a later change if you don't mind—and keep this change focused on just the fix you have here.
There was a problem hiding this comment.
I did this while debugging ... the output was easier to read for me this way.
Example:
acousticbrainz: attribute 'gender' of 'M83 - - Ludivine' set to 'male'
But, anyway, you are correct. I can revert it if you like.
There was a problem hiding this comment.
It's probably best to revert this (and the other log statements too) if not just because it adds unrelated changes/noise to this PR.
There was a problem hiding this comment.
Reverted them.
@sampsyo
sampsyo
added a commit
that referenced
this pull request
Apr 30, 2019
Fix for #2790 - acousticbrainz: Really small float values are stored as strings
sampsyo
added a commit
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor-PR for 3233. Fixes #2790