Make pathlib dependency in tests conditional #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already do this in the optional dependency section so this shouldn't cause any problems. It's only used by the `thumbnails` plugin.
sampsyo
added a commit
that referenced
this pull request
May 30, 2019
Make pathlib dependency in tests conditional
|
Good call; thanks! I added a quick note to the changelog so the Debian people (and anyone else who's doing a similar thing) know they can remove that patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do this in the optional dependency section so this shouldn't cause any problems. It's only used by the
thumbnailsplugin.I noticed that Debian was carrying a patch to remove this line since they install beets with Python 3 only and don't have a Py3 package for pathlib.