Absubmit improvements #3318
Merged
Absubmit improvements #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great!! FWIW, we have used |
sampsyo
reviewed
Jun 25, 2019
docs/plugins/absubmit.rst
Outdated
| that already have it. | ||
| Default: ``no``. | ||
| - **dry**: No analyze and submit of AcousticBrainz data but print out the | ||
| items which would be processed |
There was a problem hiding this comment.
“No” -> “Do not”. Also, missing a period here.
There was a problem hiding this comment.
Okay thx for the fast review. Your project is fun to work with.
|
|
Awesome; thank you!! Merged with a few small tweaks. ✨ |
sampsyo
added a commit
that referenced
this pull request
Jun 28, 2019
sampsyo
added a commit
that referenced
this pull request
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just wanted to have the possibility to skip items which have already Acousticbrainz data (which is now default).
-force will go back to the old behavior
-dry will show only the items which would be processed
see
https://discourse.beets.io/t/acousticbrainz-for-big-libraries/378