util.command_output: return stderr, too #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return a namedtuple CommandOutput(stdout, stderr) instead of just stdout from util.command_ouput, allowing separate access to stdout and stderr. This change is required by the ffmpeg replaygain backend (GitHub PullRequest beetbox#3056) as ffmpeg's ebur128 filter outputs only to stderr.
|
I'm kind of lost with this test failure. The exception seems to originate in In this branch neither the bpd plugin, nor the space of available addresses has been changed. My best guess is that this is an existing bug that surfaces now due to unhappy timing (and would disappear when rerunning the tests). Any help? |
|
Looks like an unstable test - I just re-ran the tests for this branch on Travis and it has passed now 😕 |
|
Indeed; we do have problems with that test. There's more in #3309. |
sampsyo
reviewed
Jul 14, 2019
After commit `30395911 util.command_output: return stderr, too`, `command_output` returns a tuple of stdout and stderr. Document that change by adding a changelog entry and add a usage note to `command_output`'s docstring.
sampsyo
added a commit
that referenced
this pull request
Jul 15, 2019
util.command_output: return stderr, too
sampsyo
added a commit
that referenced
this pull request
Jul 15, 2019
|
Looks perfect. Thanks again for separating this out! Merged. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return a namedtuple CommandOutput(stdout, stderr) instead of just stdout from
util.command_ouput, allowing separate access to stdout and stderr.
This change is required by the ffmpeg replaygain backend (GitHub
PullRequest #3056) as ffmpeg's ebur128 filter outputs only to stderr.