-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to force forward slashes in paths #3334
Add option to force forward slashes in paths #3334
Conversation
Hope the CI gets green =) FYI @sampsyo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! Any chance you could add the new option to the documentation for both plugins? (See the .rst
files in the docs
directory.)
Thanks for the big review ! I have (if I am not mistaken) integrated all your suggestions and some doc. You can take another look @sampsyo =) |
0080c24
to
076a82d
Compare
Cool! Could you take a look at the CI results? Looks like the new test is failing: And the style checker has some suggestions: |
It's all green now but I am not sure if the approach I used to fix the tests is the correct one
|
That's fine, but because all paths in beets are bytestrings, it might be even more accurate to just change the test:
|
Because **all** the path are bytestrings
Simplified it ! Tell me if you catch other things that went off my radar :) |
…ption Add option to force forward slashes in paths
Looks wonderful! Thank you for taking care of this! Merged. 😃 ✨ 🚀 |
Yaaaaay!!! 🚀 🤘 😊
Le jeu. 25 juil. 2019 à 04:15, Adrian Sampson <notifications@github.com> a
écrit :
… Looks wonderful! Thank you for taking care of this! Merged. 😃 ✨ 🚀
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3334?email_source=notifications&email_token=AAJQMSRYSHH467IJ6RXMKF3QBEEEJA5CNFSM4IGFU4D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2YEAJA#issuecomment-514867236>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJQMSVBOONQMJWMGP7UTZTQBEEEJANCNFSM4IGFU4DQ>
.
|
closes #3331