-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discogs_labelid
and discogs_artistid
fields
#3413
Conversation
I have added some new fields to |
Hi! This seems totally reasonable—storing the label and artist IDs seems useful. But for what it's worth, we don't actually need to add either of these to MediaFile to get started. They can just be stored in the database. Any chance you could add a quick note to the changelog? |
I've updated the changelog. Do you think it's worth it for me to start work on having the discogs plugin leave the |
Looks good! We can merge this now, if you think it's ready. On those two other issues:
|
I'm happy for this to get merged now, thanks. I'll start looking at the other two issues over the next few days. Indeed #2866 is a bit daunting but I'm up for the challenge :) Thanks for the advice! |
Awesome; thanks!! |
This is missing |
This patch adds some extra discogs fields. I see this as a step forward towards not having the discogs plugin pollute/overwrite the
mb_albumid
/etc fields.