Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get performer names and roles #3557

Closed
wants to merge 3 commits into from
Closed

Conversation

dosoe
Copy link
Contributor

@dosoe dosoe commented Apr 18, 2020

Gets the performer names and instruments/roles, puts them into a long list in the form performer1 (instrument1), performer2 (instrument2) . It has a few shortcomings:

  • it uses the names of the performers, which can be tricky (think of artists that use another alphabet)
  • if a performer has several roles, he appears several times
  • I don't look at the precise roles: if someone sings Carmen in an opera, she will appear as performer (soprano vocals)
  • it creates one tag performer, not one tag for each instrument/role

However, as discussed in #2563 (comment) this could be a start to tackle this issue.

@dosoe dosoe marked this pull request as draft April 18, 2020 17:11
@dosoe
Copy link
Contributor Author

dosoe commented Apr 18, 2020

Right now it looks at attributes, which can either be the instruments/voices or one of the three: additional, guest, solo. This means that I sometimes end up with performers that look like: Nikolaus Harnoncourt (conductor), Concentus Musicus Wien (performing orchestra), Ludwig Baumann (bass vocals, solo), Kurt Equiluz (solo, tenor vocals), Philip Langridge (solo, tenor vocals), Marjana Lipovšek (alto vocals, solo), Thomas Moser (solo, tenor vocals), Felicity Palmer (solo, soprano vocals), Arnold Schoenberg Chor (choir vocals). MB being what it is, the implementation of these additional attributes is wildly inconsistent and (at least for classical music) rarely used. However, while I would tend to remove these attributes, some may want to keep them, so what should be done?

@stale
Copy link

stale bot commented Nov 18, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 18, 2020
@stale stale bot closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant