Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support secure Plex connections #3619

Merged
merged 2 commits into from
Jun 9, 2020
Merged

feat: support secure Plex connections #3619

merged 2 commits into from
Jun 9, 2020

Conversation

mtrolley
Copy link
Contributor

@mtrolley mtrolley commented Jun 8, 2020 •
edited
Loading

Attempt to fix issue #2871.

Adds two new options to the plexupdate config:

  • secure - boolean of whether to use secure connections or not
  • ignore_cert_errors - boolean of whether to ignore certificate errors

@mtrolley mtrolley marked this pull request as draft June 8, 2020 21:37
@mtrolley mtrolley marked this pull request as ready for review June 8, 2020 23:01
@sampsyo
Copy link
Member

sampsyo commented Jun 8, 2020

Wahoo; this looks awesome! Thanks!!

This is a ridiculous nitpick, but could we just call the option secure instead of use_secure? The shorter names seems perfectly descriptive.

Also, would you mind adding a quick changelog entry to docs/changelog.rst describing the new feature?

@mtrolley
Copy link
Contributor Author

mtrolley commented Jun 9, 2020

Sure thing, I'll make the changes now.

sampsyo
sampsyo approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay; looks awesome! Thanks again.

@sampsyo sampsyo merged commit 9b47e4f into beetbox:master Jun 9, 2020
@mtrolley mtrolley deleted the topic/plex-secure-connections branch June 9, 2020 00:32
@mtrolley mtrolley mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampsyo sampsyo sampsyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtrolley @sampsyo