AURA: Add aura plugin and docs #3758
Conversation
|
It turns out that a lot of files (including most plugins) are ignored by flake8 in setup.cfg. |
Follows the google docstring style: https://google.github.io/styleguide/pyguide.html#38-comments-and-docstrings
So if not run through beet aura then default values will be available
|
Hello, I'd suggest a slight precision in the documentation about the reverse proxy : when proxying with Apache, one have to put a trailing slash to the app URL. Thanks for this plug-in ! |
|
@martinkirch That's good to hear! Not just luck, it should work for all beets fields including flexible ones :-)
|
There was a problem hiding this comment.
With profuse apologies for taking so long to get around to reviewing this, I finally got a chance to read through with a fine-toothed comb. This is incredibly great work and I'm super excited. The implementation seems solid, of course, but I also think this is a super useful exercise to have done to "debug" the AURA spec. Much of the stuff under "Issues" in the docs are actually not the fault of the plugin at all but should trigger reflection in the design of AURA.
I only have a few very tiny nitpicks here and there. I would love to merge this if you're still up for it!
Get rid of ` is not None` Change `len(x) == 0` to `not x` Change `x is None` to `not x`
|
No need to apologize! Thank you for looking through in so much detail 😄 Still working on the tests.... Seems like there are some linting errors since dc0350d. Should I rebase or something to get rid of those, or is it not a problem? P.S. Apologies if the name change was confusing :-) |
|
Agh; those linter errors! This is one of those cases where the style checker gets updated and reclassifies some old code as an error. I believe we resolved this through configuration recently—any chance you could merge or rebase to make sure this branch also has that updated configuration (which should eliminate those spurious errors)? And yay, I'm glad you're still interested! 😃 🚀 Not confused by the name change yet. At least your avatar is still the same pleasant circle. 😆 |
displayable_path may remove 'bad' characters, yielding a wrong path. Also use track.path rather than track.destination() as that is where the file is actually located rather than where it should be located according to the beets path system.
Ensure aura branch has updated configuration to eliminate spurious linter errors from the style checker.
After discussion here: beetbox/beets#3758 (comment)
|
Ok, I've set the server version, added a changelog entry, and the linter errors are no more 😄 Still no tests, but they will probably be delayed (again) since I have exams coming up soon :( |
|
Well, that's awesome news! How would you feel about merging this even before there are tests? It seems worthwhile enough to have it in-tree—then we can come back to testing in a separate PR. (Feel free to hit the green button yourself if you agree. 😃) |
|
Done 🎉 |
|
Wahoo! I am positively thrilled. Thanks for the careful work, both on this plugin and on the spec!! ✨ 🚀 |
This is a server implementation of an AURA server.
tox -e lintfails (see here), which would be easy enough to fix but puzzles me because no other plugins with the same "problems" cause an error. Does anyone know what's up with that?