Feature/empty config #3782
Merged
Feature/empty config #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
reviewed
Oct 24, 2020
beets/ui/commands.py
Outdated
| @@ -1691,7 +1691,10 @@ def config_func(lib, opts, args): | |||
| # Dump configuration. | |||
| else: | |||
| config_out = config.dump(full=opts.defaults, redact=opts.redact) | |||
| print_(util.text_string(config_out)) | |||
| if config_out != '{}\n': | |||
There was a problem hiding this comment.
Maybe config_out.strip() != '{}' to avoid white-space sensitivity?
| @@ -6,6 +6,7 @@ Changelog | |||
|
|
|||
| New features: | |||
|
|
|||
| * When config is printed with no available configuration a new message is printed. | |||
There was a problem hiding this comment.
Linking to the issue number here might be cool.
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"beet config with empty configuration could show a message #3779"
I added an if-clause if the config output was empty and print a different output if it is.