Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return None for lyrics if Tekstowo fails to extract lyrics #3994

Merged
merged 1 commit into from
Jul 3, 2021
Merged

return None for lyrics if Tekstowo fails to extract lyrics #3994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion beetsplug/lyrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,10 @@ def extract_lyrics(self, html):
if not soup:
return None

return soup.find("div", class_="song-text").get_text()
c = soup.find("div", class_="song-text")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick: Better rename this variable to something meaningful, e.g. lyrics_div (which is a name also used by another lyrics source).

if c:
return c.get_text()
return None


def remove_credits(text):
Expand Down