Get genres from both musicbrainz releases and release-groups. #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat; this seems like a very good idea! I'm in favor. It looks like there are a couple of style nitpicks. And could you also please add a note to the changelog? I'm also not sure whether there's somewhere in the documentation we should mention this; if we currently describe the MB genre stuff anywhere, maybe it needs a mention there. |
|
Thanks for the quick response! I added a changelog, docs tweak, and addressed the lint error |
aereaux
force-pushed
the
add_genres
branch
4 times, most recently
from
f0f4ec7 to
4f05bfa
Compare
This adds the votes from each. This also changes the behavior to reset tags if the genre option is enabled and no tags are received from musicbrainz. This also sorts genres by the number of votes.
|
Nice; this looks great! Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the votes from each.
This also changes the behavior to reset genre tags if the genre option is
enabled and no tags are received from musicbrainz.
This also sorts genres by the number of votes.
This is typically more useful because release-groups are usually better tagged, and now the %first function can be used to get the most popular genre tag. Let me know if there are any other improvements I could make here.
To Do
docs/to describe it.)docs/changelog.rstnear the top of the document.)