Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4080 #4085

Merged
merged 9 commits into from
Oct 5, 2021
Merged

Fix #4080 #4085

merged 9 commits into from
Oct 5, 2021

Commits on Oct 2, 2021

  1. Fix beetbox#4080 

    Tested with
https://www.discogs.com/SHOUSE-Love-Tonight-Robin-Schulz-Remix/release/20356324
https://www.discogs.com/release/20356324-SHOUSE-Love-Tonight-Robin-Schulz-Remix
    @arogl
    arogl committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    c4f2fff View commit details
    Browse the repository at this point in the history

  2. changelog

    @arogl
    arogl committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    b935346 View commit details
    Browse the repository at this point in the history

  3. Fix lint error

    @arogl
    arogl committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    39def81 View commit details
    Browse the repository at this point in the history

  4. Updated after feedback from @wisp3rwind

    @arogl
    arogl committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    ade9978 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2021

  1. Update comment around Discogs-ID

    @arogl
    arogl committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    a8b8d05 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Updated as per feedback from @wisp3rwind 

    I think I have the match.group correct
I'll also try and look at tests to make sure we can check
    @arogl
    arogl committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    db0431d View commit details
    Browse the repository at this point in the history

  2. Update to extract regex testing from album_for_id

    @arogl
    arogl committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    f7539b3 View commit details
    Browse the repository at this point in the history

  3. Add tests for range of discogs id extraction

    @arogl
    arogl committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    109f4fa View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Final clean up

    @arogl
    arogl committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    b880e2d View commit details
    Browse the repository at this point in the history