Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the gmusic plugin #4130

Merged
merged 1 commit into from
Nov 1, 2021
Merged

remove the gmusic plugin #4130

merged 1 commit into from
Nov 1, 2021

Conversation

wisp3rwind
Copy link
Member

Description

Fixes #4089.

sampsyo
sampsyo approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent; thanks for doing this. Adding a removal warning is a great alternative to just deleting the files altogether.

@wisp3rwind
Copy link
Member Author

Excellent; thanks for doing this. Adding a removal warning is a great alternative to just deleting the files altogether.

I was going to ask how we should handle this, but then I noticed that the freedesktop plugin had been deprecated in a similar manner before.

@wisp3rwind wisp3rwind merged commit 8228505 into beetbox:master Nov 1, 2021
@wisp3rwind wisp3rwind deleted the pr_rm_gmusic branch November 1, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampsyo sampsyo sampsyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Play Music is dead, let's remove the gmusic plugin
2 participants
@wisp3rwind @sampsyo