Use short-circuit evaluation in AndQuery and OrQuery (fix #4145) #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow; what an elegant fix! It's nice that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the performance of
dbcore.AndQuery.matchanddbcore.OrQuery.match.They would evaluate all queries and construct a list of all query results and then pass that list to
all/any.This modification passes a generator to
all/any, which allows to stop querying at the first false / true result (short-circuit evaluation).I guess we could also code the whole loops so that we do not run into the same issue accidentally.
Fixes #4145
Related to #2388 ?
To Do