Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved fix for Unicode mistakes in atomic move #4209

Merged
merged 6 commits into from
Jan 11, 2022
Merged

Improved fix for Unicode mistakes in atomic move #4209

merged 6 commits into from
Jan 11, 2022

Commits on Dec 27, 2021

  1. Fix copying for atomic file moves 

    Fixes #4168. Also closes #4192, which it supersedes.

The original problem is that this implementation used bytestrings
incorrectly to invoke `mktemp`. However, `mktemp` is deprecated, so this
PR just avoids it altogether. Fortunately, the non-deprecated APIs in
`tempfile` support all-bytes arguments.
    @sampsyo
    sampsyo committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    4bb695b View commit details
    Browse the repository at this point in the history

  2. Changelog for #4168 fix

    @sampsyo
    sampsyo committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    592c3fa View commit details
    Browse the repository at this point in the history

  3. Use bytes for destination base name 

    This is mostly "defensive programming": clients *should* only call this
on bytestring paths, but just in case this gets called on a Unicode
string path, we should now not crash.
    @sampsyo
    sampsyo committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    de3eedc View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Provide consistent types to NamedTemporaryFile

    @sampsyo
    sampsyo committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    bb13f37 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Two more syspath calls

    @sampsyo
    sampsyo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    6868388 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Merge branch 'master' into atomic-move-fix

    @sampsyo
    sampsyo authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    1962223 View commit details
    Browse the repository at this point in the history