Database parental directories creation if not exist

beets/dbcore/db.py

@@ -901,8 +901,19 @@ class Database:
     data is written in a transaction.
     """
 
+    # Check whether parental directories exist.
+    def _path_checker(self, path):
+        if not isinstance(path, bytes) and path == ':memory:':  # in memory db
+            return
+        newpath = os.path.dirname(path)
+        if not os.path.isdir(newpath):
+            from beets.ui.commands import database_dir_creation
+            if database_dir_creation(newpath):
+                os.makedirs(newpath)
+
     def __init__(self, path, timeout=5.0):
         self.path = path
+        self._path_checker(path)
         self.timeout = timeout
 
         self._connections = {}

beets/ui/commands.py

@@ -1398,6 +1398,15 @@ def show_version(lib, opts, args):
 version_cmd.func = show_version
 default_commands.append(version_cmd)
 
+# database_location: return true if user
+# wants to create the parent directories.
+
+
+def database_dir_creation(path):
+    # Ask the user for a choice.
+    return ui.input_yn("{} does not exist, create it (Y/n)?"
+                       .format(displayable_path(path)))
+
 
 # modify: Declaratively change metadata.
 

docs/changelog.rst

@@ -7,6 +7,7 @@ Changelog
 Changelog goes here!
 
 New features:
+* Create the parental directories for database if they do not exist.
 
 * :ref:`musicbrainz-config`: a new :ref:`musicbrainz.enabled` option allows disabling 
   the MusicBrainz metadata source during the autotagging process

docs/guides/main.rst

@@ -142,7 +142,8 @@ place to start::
 
 Change that first path to a directory where you'd like to keep your music. Then,
 for ``library``, choose a good place to keep a database file that keeps an index
-of your music. (The config's format is `YAML`_. You'll want to configure your
+of your music. Beets will prompt you if the parental directories for database do
+not exist. (The config's format is `YAML`_. You'll want to configure your
 text editor to use spaces, not real tabs, for indentation. Also, ``~`` means
 your home directory in these paths, even on Windows.)
 

test/test_dbcore.py

@@ -19,6 +19,8 @@
 import shutil
 import sqlite3
 import unittest
+from random import random
+from unittest import mock
 
 from test import _common
 from beets import dbcore
@@ -760,8 +762,31 @@ def test_no_results(self):
             ModelFixture1, dbcore.query.FalseQuery()).get())
 
 
+class ParentalDirCreation(unittest.TestCase):
+    @mock.patch('builtins.input', side_effect=['y', ])
+    def test_create_yes(self, _):
+        non_exist_path = "ParentalDirCreationTest/nonexist/" + str(random())
+        try:
+            dbcore.Database(non_exist_path)
+        except OSError as e:
+            raise e
+        shutil.rmtree("ParentalDirCreationTest")
+
+    @mock.patch('builtins.input', side_effect=['n', ])
+    def test_create_no(self, _):
+        non_exist_path = "ParentalDirCreationTest/nonexist/" + str(random())
+        try:
+            dbcore.Database(non_exist_path)
+        except OSError as e:
+            raise e
+        if os.path.exists("ParentalDirCreationTest/nonexist/"):
+            shutil.rmtree("ParentalDirCreationTest")
+            raise OSError("Should not create dir")
+
+
 def suite():
     return unittest.TestLoader().loadTestsFromName(__name__)
 
+
 if __name__ == '__main__':
     unittest.main(defaultTest='suite')