Added remixer field #4549
Merged
Added remixer field #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
reviewed
Nov 18, 2022
beets/autotag/mb.py
Outdated
| @@ -202,6 +202,19 @@ def _flatten_artist_credit(credit): | |||
| ) | |||
|
|
|||
|
|
|||
| def _get_remixer_names(relations): | |||
| """ Given a list representing the artist relationships extract the names of | |||
There was a problem hiding this comment.
Suggested change
| """ Given a list representing the artist relationships extract the names of | |
| """Given a list representing the artist relationships extract the names of |
beets/autotag/mb.py
Outdated
| @@ -202,6 +202,19 @@ def _flatten_artist_credit(credit): | |||
| ) | |||
|
|
|||
|
|
|||
| def _get_remixer_names(relations): | |||
There was a problem hiding this comment.
Maybe we should very slightly generalize this for future-proofing… we could make it take the relation type as a parameter, and make it default to 'remixer' for now? I can imagine wanting to collect other relationships in a similar way.
|
I updated the PR to include you feedback. I also noticed I introduced a failing test by changing the order of the parameters of the _make_track function so I added the remixer parameter as the last parameter. |
|
Awesome!! Seems like everything's in order. Thanks again!! |
|
I really liked working on beets since I also use it myself. This will probably not be my last PR for beets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4428
Adds the remixer field from the musicbrainz database to the beets library. I haven't added any documentation since I didn't know if it is necessary for the changes I made.
To Do
docs/to describe it.)docs/changelog.rstnear the top of the document.)