Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flowchart of beet's import process to the documentation resources #4583

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Serene-Arc
Copy link
Contributor

In an attempt to learn more about the codebase of beets, I've been making a flowchart of the process of importing something into beets. There isn't much in the documentation about the technical details, the nitty gritty stuff, so I thought that, if this would be appropriate for the documentation, that the chart might be helpful for other people wanting to familiarise themselves with the process that beets goes through.

I'm still working on it but I'm making a draft PR if anyone would like to help, either by pointing out mistakes I've made, increasing the detail of parts, or parts that needs to be added to the flowchart. So, thoughts anyone?

@RollingStar
Copy link
Collaborator

Probably doesn't matter here, but I believe you can generate charts like this from the code itself.

@Serene-Arc
Copy link
Contributor Author

You can generate call charts but my goal with this isn't the exact same thing. I'm trying to explain the process, which isn't the same as the calls to various functions, though it is close in some places.

@JOJ0
Copy link
Member

JOJ0 commented Jan 14, 2023

I think a chart like this is really helpful. I try to understand bits and pieces of the flow of beets import time and time again when working on beets but it's often that it's hard to keep the whole big picture in mind.

Do you have an idea where in the docs this could live?

Also it should have a timestamp and tell that it's displaying how things work(ed) at a specific point in time. Certainly a lot of parts are pretty stable and wont change any time soon but still, noting the time of generation makes sense I guess if it should be part of the developers docs.

@Serene-Arc
Copy link
Contributor Author

I would place it in the developers notes in the docs, in a page perhaps elaborating on it. My goal is to have a big, sprawling flowchart where people can zoom in if needed. Like when I need to know about the matching process, there's a sub-flowchart that I can look to specifically.

Adding a specific commit/timestamp is a great idea, that should definitely be done. I'm not sure how much it would really change between versions since it's not supposed to be a call graph, but a step-by-step process that only sometimes corresponds with a function call. I wouldn't expect that to change significantly.

Over time it could be expanded with additional parts but I was going through the import process so that's what represented at the moment.

JOJ0 added a commit to jpluscplusm-forks/beetbox.beets that referenced this pull request Feb 27, 2023
and include linking to manual fixin tutorial.
JOJ0 added a commit to jpluscplusm-forks/beetbox.beets that referenced this pull request Feb 27, 2023
and include linking to manual fixin tutorial.
JOJ0 added a commit to jpluscplusm-forks/beetbox.beets that referenced this pull request Feb 27, 2023
and include linking to manual fixin tutorial.
JOJ0 added a commit to jpluscplusm-forks/beetbox.beets that referenced this pull request Feb 28, 2023
and include linking to manual fixing tutorial.
JOJ0 added a commit to jpluscplusm-forks/beetbox.beets that referenced this pull request Feb 28, 2023
and include linking to manual fixing tutorial.
@stale
Copy link

stale bot commented May 20, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 20, 2023
@stale stale bot closed this Jun 10, 2023
@Serene-Arc Serene-Arc reopened this Jun 10, 2023
@stale stale bot removed the stale label Jun 10, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@RollingStar
Copy link
Collaborator

Keep alive

@Serene-Arc Serene-Arc removed the stale label Oct 18, 2023
Copy link

stale bot commented Mar 17, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants